Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YJIT: Move help descriptions to options.rs #8583

Merged
merged 5 commits into from
Oct 4, 2023
Merged

YJIT: Move help descriptions to options.rs #8583

merged 5 commits into from
Oct 4, 2023

Conversation

k0kubun
Copy link
Member

@k0kubun k0kubun commented Oct 3, 2023

We sometimes forget adding entries to yjit_options or update defaults in it. To prevent that, this PR moves it to options.rs and puts it near OPTIONS.

@matzbot matzbot requested a review from a team October 3, 2023 22:59
maximecb
maximecb reviewed Oct 4, 2023
View reviewed changes
ruby.c Outdated Show resolved Hide resolved
maximecb
maximecb reviewed Oct 4, 2023
View reviewed changes
yjit/src/options.rs Outdated Show resolved Hide resolved
@nobu
Copy link
Member

nobu commented Oct 4, 2023

What about https://github.com/nobu/ruby/pull/new/usage_line ?

@k0kubun
Copy link
Member Author

k0kubun commented Oct 4, 2023

What about https://github.com/nobu/ruby/pull/new/usage_line ?

Looks good. I rebased this PR based off of your patch.

@k0kubun k0kubun merged commit 7db6f44 into ruby:master Oct 4, 2023
94 checks passed
@k0kubun k0kubun deleted the yjit-options branch October 4, 2023 17:25
XrXr added a commit to XrXr/ruby that referenced this pull request Oct 4, 2023
@XrXr
YJIT: add --yjit-disable-code-gc
f6c2f76 
Will need a rebase for integrating with master since:
 - ruby#8582
 - ruby#8583
k0kubun pushed a commit to k0kubun/ruby that referenced this pull request Oct 5, 2023
@XrXr @k0kubun
YJIT: add --yjit-disable-code-gc
2ed8d10 
Will need a rebase for integrating with master since:
 - ruby#8582
 - ruby#8583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nobu nobu nobu left review comments

@maximecb maximecb maximecb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@k0kubun @nobu @maximecb